I actually traveled in June 2012, not September.
These accommodations are decent for university students - mind that fact. This place is not a hotel, so the mattress is a bit firm, the walls a bit thin, the space a bit tight (for two people). However, none of these "drawbacks" negatively affected me because I was content with the money I saved by staying here.
The buffet breakfast was a great deal; it's mostly Scottish fare (as expected) in a generous spread. I made a couple of hard-boiled egg sandwiches with the large croissants available and didn't need to eat until early dinner.
Had quite the walking adventure when trying to return to the halls from town on the first night. My travel companion and I went the "back way," literally behind the university grounds up the steep hill next to Holyrood Park. Getting lost is a great way to familiarize yourself with the area, but perhaps earlier than 23:00 (although the sky was still light!).
A ten minute walk gets you to the High Mile, which is where we spent our two days. The hop on-off bus was a smart choice, especially because of the commentary offered (bring your own headphones for the perfect fit).More