It has been 40 years since I last visited Hershey, PA. But my wife and I wanted to take our 10 year old daughter to experience it. We would be staying from Saturday night through Wednesday night. Upon check-in, the front desk staff was courteous and asked whether we had a floor preference (likely because we were staying so long). Since some reviews of this hotel indicated the pool odor was a concern on the first floor, we choose the 3rd floor. It was close to a stairway and down the hall from the elevator. There is only 1 small elevator for this hotel. At times, it would take a while to reach us, but we typically used the stairs.
The suite was small in comparison to other suite hotels we've stayed in, with no full/closable partition between the "family room/kitchen" and bedroom, but that was okay. Would have been nice since we stayed up later than our daughter, who slept on the sofa bed. Being that it was a fairly small suite, when the sofa bed was open, it was really impossible to walk around it from the master bed to the kitchen area. Of course, there's nothing Springhill can do about this, but I wanted to note it. We rarely watched TV (it was an HDTV, but programming was definitely not in HD...just stretched to fit. Again, not a real issue). The room was clean and beds were comfy. Our daughter slept very well on the sofa bed. There was a sink which was separate from the shower/toilet room. The only issue with the room was the towel rack (metal) falling apart. It just needed tightening up with a screwdriver and after calling down to the front desk prior to going out for dinner, it was fixed by the time we returned. Next to the master bed was a iHome clock radio that can charge an iPad, iPhone, etc, and you can even wake to your device's music. Nice touch.
The kitchenette consisted of a dorm-room sized microwave, dorm fridge (no real freezer), and small single well sink, along with a coffee maker (can produce hot water for tea), condiments, and counter space. Since our stay was quite a few days, a larger refrigerator would have been nice, since we brought back leftovers from our eating out.
There is a complementary breakfast in the mornings, but we had visited the nearby Giant Foods grocery store for breakfast stuff. I did visit the breakfast in the lobby once and it had a good selection of cereals, yogurt, juice, fruit and a couple of hot options. I think anyone would have been able to find something they liked.
The chlorine smell from the pool that some reviewers complained about didn't seem to be that obvious, except on a few occasions...and even then, it wasn't horrible. Just typical of having an indoor pool on a major hallway next to the elevator. The pool itself was tiny and the water was very chilly (the entire time we were there). With another family with 2-3 kids in the pool, we found ourselves not really enjoying the pool much. There was a hot tub, but it wasn't working on one day and my wife said it was on when she went to the pool a few days later. There is an exercise room but we didn't utilize it.
There is an antique auto museum next door to the hotel that charges for admission but really has a nice collection. It is partially assisted by the Smithsonian. We visited it on the last day of our time in Hershey. They are open from 9-5. HersheyPark and Chocolate World is a straight shot down from the hotel (couple of minutes at the most). A soft-serve ice cream place is next door, but nothing else but nice countryside is in the immediately vicinity.
If you're looking for a great location and a trusted hotel name, Springhill Suites-Hershey can't be beat. The suites could be bigger as could some of the kitchen appliances, but it served our needs during our long stay.