I managed to frequent three different Starbucks locations in Shanghai during my stay. They were all up to Starbucks' usual international standards for decent coffee and courteous staff.
The shop on Henan Middle Road, one block south of East Nanjing Street, was closest to my hotel, which did not have a restaurant. I went here most days for my morning coffee; for part of my stay they had a very tasty special with a breakfast croissant (beef and cheese) at half price when you bought a coffee. I thought this was particularly good value for your money for Starbucks, which is a premium coffee shop.
Staff here were particularly friendly since I quickly got identified as a "regular," and I was often one of the first customers in the shop. I always had my choice of tables here, and this was a nice way to start my day before heading out for some sightseeing. This shop in particular seemed spacious and comfortable.
I also dropped by the shop at People's Square one afternoon, and one over by the Yu Gardens (the one which had a few outdoor tables; see photo). The Yu Gardens outlet was especially crowded with a sizeable line up for service when I visited in the afternoon after seeing the Gardens. Customers here were sitting cheek-by-jowl.
All three shops had friendly and efficient staff, and reliable coffee.
It must be a cultural thing in China, but these stores tended to have milk but no cream set out at the self-service station; cream was available behind the counter if you asked staff.
If you own or manage Starbucks, register now for free tools to enhance your listing, attract new reviews, and respond to reviewers.