We visited this while on a 17-day tour of China, so there was inadequate time to do it justice (and no free time to allow us to go back). Our guide (who seemed to be very knowledgeable) said that it and the Shanghai Museum were the two best Museums in China. That may have been because they were the two major museums we were seeing, but based on our limited experience visiting other museums, it is probably correct. While the Shaanxi Museum did not have as extensive holdings as the Shanghai Museum, it had a lot of good stuff and most of it was very well displayed. You can get much better views of some items from the terra cotta army here than you can at the burial site out of town. It is very definitely worth a visit if in town.
This review is the subjective opinion of a TripAdvisor member and not of TripAdvisor LLC.