I lasted stayed at the St. Joseph some 12 years ago. That was my first trip outside of Europe, and at the time it seemed a reasonably nice hotel, and I was probably a little less particular in those days.
Having just returned from a second stay, of 10 nights duration, I have to report a certain disappointment. Yes, it is inexpensive, but little or nothing has been done to bring the hotel up to date. The reception area is still gloomy and a little depressing, and the theme continues once you get to your room. On the positive side, the room was basically kept clean and the bed linen changed at least every other day. I found the covers to be rather thin though - the extra blankets in the wardrobe smelled musty - and combined with the (necessary) aircon, sometimes made for a cold night's sleep, as the higher settings on the aircon unit were a little too warm in September.
Also the street noise, which seems to have increased at night post-revolution, can be quite bothersome, and the curtains do little to shut it out. Ask for a room towards the back of the hotel and on a higher floor if you are a light sleeper!
The Tudor Rose (formerly 'Classic') restaurant is also very much as I remember it - clean, again with subdued lighting, and offering palatable, though not outstanding, meals. I have to say I did not fancy the breakfast at all, and made other arrangements. The number of decent and affordable restaurants in the area these days reduces the reason to eat here, although the food on offer at the rooftop pool area is quite acceptable. I just wouldn't bother going half board. On the subject of the rooftop area, again it is very much the same as it was years ago - a pleasant place to spend the afternoon, just a bit tatty and dated around the edges. Excellent views across the Nile.
In conclusion, there are now more newer and more appealing options within the same price range, and if I was on a tight budget again I would probably stay in one of those - if only to avoid the caleche and taxi drivers now camped 16 hours a day outside the St. Joseph's entrance.
This review is the subjective opinion of a TripAdvisor member and not of TripAdvisor LLC.